Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port file system inspector #575

Merged
merged 20 commits into from
Dec 22, 2020
Merged

Port file system inspector #575

merged 20 commits into from
Dec 22, 2020

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented Dec 3, 2020

Followup on tikv/rocksdb#216, port related interface to rust, add file_system_inspected_env factory method.

Signed-off-by: tabokie xy.tao@outlook.com

@tabokie
port file system inspector
ec905d5 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
comment fix
514f826 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
update rocksdb
93f09c3 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
fix obsolete declare
e80a748 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
revert format
3bc7f0d 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
update rocksdb
87d46f5 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
revert io_type from interface
3a9915a 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
fix typo
a1f8579 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
revert format
4413adc 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
cleanup
b9f64fa 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
reflect rocksdb changes
ec0d2de 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
revert format
6a08530 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
update rocksdb
288bab8 
Signed-off-by: tabokie <xy.tao@outlook.com>
yiwu-arbug
yiwu-arbug reviewed Dec 21, 2020
View reviewed changes
Copy link
Collaborator

@yiwu-arbug yiwu-arbug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add some unit test to make sure the ffi works?

librocksdb_sys/crocksdb/crocksdb/c.h Outdated Show resolved Hide resolved
librocksdb_sys/crocksdb/crocksdb/c.h Outdated Show resolved Hide resolved
librocksdb_sys/crocksdb/c.cc Show resolved Hide resolved
@tabokie
address comments
9a07f31 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
add unit test
b340128 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
update rocksdb
d48ef59 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
Merge branch 'master' of https://github.com/pingcap/rust-rocksdb into…
9656901 
… rusty-fs

Signed-off-by: tabokie <xy.tao@outlook.com>
yiwu-arbug
yiwu-arbug approved these changes Dec 21, 2020
View reviewed changes
Copy link
Collaborator

@yiwu-arbug yiwu-arbug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabokie
fix compile error
a7a9b5e 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
fix compile
05ad0b8 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie tabokie merged commit 63e7cea into tikv:master Dec 22, 2020
@ti-srebot ti-srebot mentioned this pull request Dec 22, 2020
Closed
@tabokie tabokie deleted the rusty-fs branch December 23, 2020 03:13
@yiwu-arbug yiwu-arbug mentioned this pull request Dec 29, 2020
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiwu-arbug yiwu-arbug yiwu-arbug approved these changes

@Connor1996 Connor1996 Awaiting requested review from Connor1996

Assignees
No one assigned
Labels
status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tabokie @yiwu-arbug @ti-srebot