Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate max_background_jobs will fail when cpu quota is less than 1 #13752

Closed
CalvinNeo opened this issue Nov 8, 2022 · 0 comments · Fixed by #14084
Closed

validate max_background_jobs will fail when cpu quota is less than 1 #13752

CalvinNeo opened this issue Nov 8, 2022 · 0 comments · Fixed by #14084
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. severity/minor type/bug The issue is confirmed as a bug.

Comments

@CalvinNeo
Copy link
Member

Bug Report

What version of TiKV are you using?

master

What operating system and CPU are you using?

all

Steps to reproduce

when cpu quota is less than 1

What did you expect?

Not sure.

What did happened?

According to https://github.com/tikv/tikv/blob/master/src/config.rs#L1240, if cpu quota is less than 1, we may get a validation error.

[FATAL] [[config.rs:400](http://config.rs:400/)] ["invalid configuration: max_background_jobs should be greater than 0 and less than or equal to 0"]

Is this by design?
@CalvinNeo CalvinNeo mentioned this issue Nov 8, 2022
Closed
@andreid-db andreid-db mentioned this issue Jan 26, 2023
Merged
@tabokie tabokie added type/bug The issue is confirmed as a bug. severity/minor affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. labels Jan 29, 2023
This was referenced Jan 29, 2023
Open
Merged
Merged
ti-chi-bot added a commit that referenced this issue Feb 15, 2023
@ti-chi-bot @andreid-db @tabokie
config: allow starting TiKV nodes with <1 CPU (#14084) (#14091)
5cdc134 
close #13586, close #13752, ref #14017, ref #14084

Signed-off-by: Andrei Dragus <andrei.dragus@databricks.com>

Co-authored-by: Andrei Dragus <andrei.dragus@databricks.com>
Co-authored-by: Xinye Tao <xy.tao@outlook.com>
ti-chi-bot added a commit that referenced this issue Mar 27, 2023
@ti-chi-bot @andreid-db
config: allow starting TiKV nodes with <1 CPU (#14084) (#14090)
339ec83 
close #13586, close #13752, ref #14017, ref #14084

Signed-off-by: Andrei Dragus <andrei.dragus@databricks.com>

Co-authored-by: Andrei Dragus <andrei.dragus@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: allow starting TiKV nodes with <1 CPU andreid-db/tikv
2 participants
@CalvinNeo @tabokie