apply: fix witness raft log gc panic and refactor

[ethercflow]

ref #12876

Signed-off-by: Wenbo Zhang ethercflow@gmail.com

What is changed and how it works?

Issue Number: ref #12876

What's Changed:

• Fix panic caused by not initialize apply_ctx.timer, the ApplyPoller releases the ownership of ApplyFsm after skip flushing, and the other ApplyPoller gets this ApplyFsm then updates applied_index and flush first, causing the applied index to flip.
• Refactor the logic of notifying the raftstore thread. In the previous method, after calling finish_for (which will update the apply_ctx.applied_res array), explicitly call notify_one to notify raftstore, resulting in redundant notifications. Now the notification is done uniformly through apply_ctx.applied_res.
• Added a separate configuration to control the interval of request voter_replicated_index

fix witness raft log gc panic and refactor

Related changes

• PR to update pingcap/docs/pingcap/docs-cn:

Check List

Tests

• Integration test
• Manual test (add detailed scripts or steps below)
  • Setup cluster use sysbench prepare as workload, turn down request voter_replicated_index interval, keep running for more than 1h. (When there was a problem before, it can be reproduced in a few minutes)

Side effects

• Performance regression
  • None

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• BusyJay
• tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[BusyJay]

Rest LGTM

[tabokie]

/merge

[ti-chi-bot]

@tabokie: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 8ac4399