pd/raftstore: support region half-split without scan #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| CheckPolicy::APPROXIMATE => { | ||
| let res = raftstore_util::get_region_approximate_middle(&self.engine, region); | ||
| if let Err(e) = res { | ||
| debug!("[region {}] failed to get approxiamte split key: {}", region_id, e); |
| host.split_key() | ||
| } | ||
| CheckPolicy::APPROXIMATE => { | ||
| let res = raftstore_util::get_region_approximate_middle(&self.engine, region); |
There was a problem hiding this comment.
Middle and approximate are not related, here looks strange.
|
Good job, BTW have you test it with pd-ctl? |
| @@ -102,6 +102,11 @@ pub trait SplitChecker { | |||
|
|
|||
| /// Get the desired split keys. | |||
| fn split_key(&mut self) -> Option<Vec<u8>>; | |||
|
|
|||
| /// Get approximate split keys without scan. | |||
| fn approximate_split_key(&self, _: &Region, _: &DB) -> Result<Option<Vec<u8>>> { | |||
There was a problem hiding this comment.
Can you combine this into split_key? We don't need to know how it gets the split key outside.
There was a problem hiding this comment.
since to get not approximate split key, we must call on_kv() first. So outside caller it does know what the policy is.
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
* add check policy for split region
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Now tikv support get region approximate middle key based on region properties, so make region half-split without scan. pingcap/kvproto#287 add a check-policy field for split-region request. And this PR makes the way of check-split to get split-key depend on policy. If SCAN, do as before, if APPROXIMATE, use approximate middle key.
limit: APPROXIMATE policy doesn't support for table-split-checker and size-split-checker.
What are the type of the changes? (mandatory)
Improvement (non-breaking change which is an improvement to an existing feature)
How has this PR been tested? (mandatory)
unit-test
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
N/A
Does this PR affect tidb-ansible update? (mandatory)
N/A
Refer to a related PR or issue link (optional)
pingcap/kvproto#287