[cherry-pick-2.1] Fix event listener issue #4132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check status of CompactionJobInfo Signed-off-by: DorianZheng <xingzhengde72@gmail.com> (cherry picked from commit 22957b7) Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
|
CI failed seem now master and release use different rust version. |
|
@DorianZheng We should add a release-2.1 branch without Titan related code in pingcap/rust-rocksdb. |
|
@siddontang yes they are on different versions now. What do you think we should do about it? How long is it between now and the next release? |
|
Ping @DorianZheng |
|
/run-all-tests |
This comment has been minimized.
This comment has been minimized.
nolouch
previously approved these changes
Feb 13, 2019
Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
DorianZheng
force-pushed
the
cherry-pick-release-2.1
branch
from
173b926
to
2ff9478
Compare
|
@overvenus I will create a release-2.1 branch for rust-rocksdb, so never mind the previous CI failed |
|
/run-integration-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1 |
Signed-off-by: DorianZheng <xingzhengde72@gmail.com>
overvenus
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Check status of CompactionJobInfo at first.
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
CI
Does this PR affect documentation (docs) update? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)