import: increase default region-split-size to 512 MiB #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the SST size to upload larger, which reduces the number of SST files needed to ingested, and improve overall speed. Signed-off-by: kennytm <kennytm@gmail.com>
nolouch
approved these changes
Mar 11, 2019
kennytm
added a commit
to kennytm/tikv
that referenced
this pull request
Mar 13, 2019
This makes the SST size to upload larger, which reduces the number of SST files needed to ingested, and improve overall speed. Signed-off-by: kennytm <kennytm@gmail.com>
huachaohuang
pushed a commit
that referenced
this pull request
Mar 14, 2019
* import: increase default region-split-size to 512 MiB (#4347) This makes the SST size to upload larger, which reduces the number of SST files needed to ingested, and improve overall speed. Signed-off-by: kennytm <kennytm@gmail.com> * import: store the intermediate SST files on disk instead of memory (#4348) * import: store the intermediate SST files on disk instead of memory The bottle-neck of Importer is in SST ingestion on the TiKV side, not disk I/O. Storing these SST in RAM will just increase the chance Importer getting killed by OOM. Signed-off-by: kennytm <kennytm@gmail.com> * import: fix #4257, restrict memory usage by RocksDB (#4350) * import: put index and filter in block cache to restrict memory usage Signed-off-by: Lonng <chris@lonng.org> Signed-off-by: kennytm <kennytm@gmail.com> * import: wait after split before scatter (#4352) Signed-off-by: kennytm <kennytm@gmail.com>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
This makes the SST size to upload larger, which reduces the number of SST files needed to ingested, and improve overall speed. Signed-off-by: kennytm <kennytm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kennytm kennytm@gmail.com
What have you changed? (mandatory)
This makes the SST size to upload larger, which reduces the number of SST
files needed to ingested, and improve overall speed.
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Tested manually using a data set with size 6.5 TB
Does this PR affect documentation (docs) update? (mandatory)
No (config for importer isn't documented in this repo 🤔)
Does this PR affect tidb-ansible update? (mandatory)
Yes (will be filed separately, together with Lightning changes)
Refer to a related PR or issue link (optional)
Part 1/7 split off from #4245
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)