coprocessor: add mod(Int/Real/Decimal) RPN functions #4727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breezewish
reviewed
May 20, 2019
|
/run-integration-tests |
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
sticnarf
reviewed
May 21, 2019
sticnarf
reviewed
May 21, 2019
sticnarf
reviewed
May 21, 2019
breezewish
reviewed
May 21, 2019
| @@ -65,6 +65,15 @@ fn plus_mapper(lhs_is_unsigned: bool, rhs_is_unsigned: bool) -> Box<dyn RpnFunct | |||
| } | |||
| } | |||
|
|
|||
| fn mod_mapper(lhs_is_unsigned: bool, rhs_is_unsigned: bool) -> Box<dyn RpnFunction> { | |||
| match (lhs_is_unsigned, rhs_is_unsigned) { | |||
| (false, false) => Box::new(RpnFnArithmetic::<IntIntMod>::new()), | |||
There was a problem hiding this comment.
Maybe we can discover some higher ordered generics to deal with these IntInt, IntUint, UintInt, UintUint later, to reduce code duplicates :) We will have many functions that is different in signed / unsigned integers. Would be too verbose if we need a standalone function for each of them.
breezewish
reviewed
May 21, 2019
|
Cool! I will click the approve button after resolving comments above. |
Signed-off-by: Lonng <heng@lonng.org>
sticnarf
previously approved these changes
May 21, 2019
breezewish
previously approved these changes
May 21, 2019
|
/run-integration-tests |
|
/run-integration-tests |
breezewish
approved these changes
May 21, 2019
sticnarf
reviewed
May 21, 2019
| #[test] | ||
| fn test_mod_real() { | ||
| let tests = vec
There was a problem hiding this comment.
Maybe we can write Option<f64> here and convert it below in the loop to make the test vec clearer. (I can do it later)
sticnarf
approved these changes
May 21, 2019
jswh
pushed a commit
to jswh/tikv
that referenced
this pull request
May 27, 2019
* coprocessor: add mod(Int/Real/Decimal) RPN functions Signed-off-by: Lonng <heng@lonng.org> * remove empty line Signed-off-by: Lonng <heng@lonng.org> * address comment Signed-off-by: Lonng <heng@lonng.org>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
* coprocessor: add mod(Int/Real/Decimal) RPN functions Signed-off-by: Lonng <heng@lonng.org> * remove empty line Signed-off-by: Lonng <heng@lonng.org> * address comment Signed-off-by: Lonng <heng@lonng.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What have you changed? (mandatory)
Add
mod(Int/Real/Decimal) RPN functionsWhat are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
unit tests