storage/gc_worker: Add more metrics (#4705) #4922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add more metrics about GC Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> * Address comments Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> * Address comments Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> * Remove redundant metrics updating Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> * Address comments Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
MyonKeminta
added
component/storage
youjiali1995
approved these changes
Jun 19, 2019
MyonKeminta
added
the
priority/release-blocker
|
/run-all-tests tidb=release-3.0 pd=release-3.0 |
|
/run-all-tests tidb=release-3.0 pd=release-3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: MyonKeminta MyonKeminta@users.noreply.github.com
What have you changed? (mandatory)
This PR cherry-picks PR #4705 which added more metrics for GC.
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Manual test, previously tested in #4705
Does this PR affect documentation (docs) or release note? (mandatory)
Does this PR affect tidb-ansible update? (mandatory)
NO