coprocessor: add a Convert trait and implement convert to decimal #5167
Conversation
|
/run-all-tests |
| for (lhs, rhs, expected) in test_cases { | ||
| let output = RpnFnScalarEvaluator::new() | ||
| .push_param(lhs.map(|f| Decimal::from_f64(f).unwrap())) | ||
| .push_param(rhs.map(|f| Decimal::from_f64(f).unwrap())) | ||
| .push_param(lhs.map(|f| f64_to_decimal(&mut ctx, f).unwrap())) |
There was a problem hiding this comment.
Maybe we can rewrite these tests using string instead.. It would be better for a unit test to test less things other than itself.
| let test_cases = vec
| return Err(invalid_type!("{} can't be convert to decimal'", self)); | ||
| } | ||
|
|
||
| let s = format!("{}", self); |
There was a problem hiding this comment.
Is this format (of f64) extract same as golang's format
There was a problem hiding this comment.
Yes (if we do not use special format string, e.g: %E/%e)
| impl ConvertTo<Decimal> for &[u8] { | ||
| #[inline] | ||
| fn convert(&self, ctx: &mut EvalContext) -> Result<Decimal> { | ||
| let dec = match Decimal::from_bytes(self)? { |
There was a problem hiding this comment.
Does this impl same as TiDB's, if we need to check carefully, I think add a TODO is better.
There was a problem hiding this comment.
Yes, they have the same implementation.
|
The reset is fine |
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
|
/run-all-tests |
…kv#5167) Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng heng@lonng.org
What have you changed? (mandatory)
Implements
ConvertTo<Decimal>for all evaluable types.What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Existing unit tests.