Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: support tls for the status server #5393

Merged
merged 3 commits into from
Mar 17, 2020

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Sep 3, 2019

What have you changed?

This PR is trying to support TLS for the status server.

What is the type of the changes?

  • New feature

How is the PR tested?

For now, it is temporarily tested manually. I will add some tests to cover it.

Does this PR affect tidb-ansible?

Yes

Refer to a related PR or issue link (optional)

Close #5340.

Release note

server: support TLS for the status server

@rleungx rleungx added S: WIP component/server Component: Server labels Sep 3, 2019
cmd/src/server.rs Outdated Show resolved Hide resolved
src/server/status_server.rs Outdated Show resolved Hide resolved
cmd/src/server.rs Outdated Show resolved Hide resolved
src/server/status_server.rs Outdated Show resolved Hide resolved
src/server/status_server.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@overvenus
Copy link
Member

Any update?

@overvenus overvenus added the status/waiting Status: Waiting for response label Sep 25, 2019
@tennix
Copy link
Contributor

tennix commented Nov 13, 2019

@rleungx Any progress on this?

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be nice if you can add a unit test.

Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test to verify that TLS status server actually works? The rest LGTM

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx removed the status/waiting Status: Waiting for response label Mar 17, 2020
@overvenus
Copy link
Member

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 17, 2020

/run-all-tests

@sre-bot sre-bot merged commit 41f6282 into tikv:master Mar 17, 2020
@you06 you06 added this to the v4.0.0-rc milestone Mar 24, 2020
zhangjinpeng87 pushed a commit to zhangjinpeng87/tikv that referenced this pull request Mar 26, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
c1ay pushed a commit to c1ay/tikv that referenced this pull request May 9, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server Component: Server status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics page not using HTTPS after TLS enabled
9 participants