Cherry-pick sst_importer: download SST from external storage + key rewrite (#5581) to release-3.1
#5689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5581) * sst_importer: download SST from external storage + key rewrite Signed-off-by: kennytm <kennytm@gmail.com> * sst_importer: update kvproto; respect required range; add some logs Signed-off-by: kennytm <kennytm@gmail.com> * sst_importer: fix clippy warning Signed-off-by: kennytm <kennytm@gmail.com> * sst_importer: do check invalid prefix; use data_key for SST range Signed-off-by: kennytm <kennytm@gmail.com> * sst_importer: use origin key for rewrite rules Signed-off-by: kennytm <kennytm@gmail.com> * sst_importer: fix clippy warning Signed-off-by: kennytm <kennytm@gmail.com> * sst_importer: make download range use post-rewrite keys; return new range Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
added
type/cherry-pick
kennytm
force-pushed
the
download-sst-3.1
branch
from
50d600e
to
7771a86
Compare
Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
force-pushed
the
download-sst-3.1
branch
from
7771a86
to
a044f85
Compare
|
/run-all-tests |
|
/run-integration-copr-test |
2 similar comments
|
/run-integration-copr-test |
|
/run-integration-copr-test |
|
/run-integration-tests |
|
/run-integration-copr-test tikv=release-3.1 |
|
@kennytm you should ignore copr-test. it not mettar |
|
@zhouqiang-cl OK. Will it be fixed 😂 |
overvenus
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed?
Cherry-pick #5581 to release-3.1.
What is the type of the changes?
Pick one of the following and delete the others:
How is the PR tested?
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No?
Does this PR affect
tidb-ansible?No
Refer to a related PR or issue link (optional)
#5581
Benchmark result if necessary (optional)
Any examples? (optional)