Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: add file lock to work around port conflict (#7355) #7447

Merged
merged 11 commits into from
Apr 23, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 13, 2020

cherry-pick #7355 to release-4.0


Signed-off-by: TXXT hunterlxt@live.com

What problem does this PR solve?

close #4323

What is changed and how it works?

add file lock to work around port conflict

Related changes

NO

Check List

Tests

  • Unit test

Side effects

Release note

Add file lock check to avoid starting multiple instances bound to the same address.

Signed-off-by: TXXT <hunterlxt@live.com>
Signed-off-by: TXXT <hunterlxt@live.com>
Signed-off-by: TXXT <hunterlxt@live.com>
Signed-off-by: TXXT <hunterlxt@live.com>
Signed-off-by: TXXT <hunterlxt@live.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 13, 2020

/run-all-tests

@sre-bot sre-bot added component/gRPC Component: gRPC type/cherry-pick Type: PR - Cherry pick labels Apr 13, 2020
@hunterlxt hunterlxt modified the milestones: v4.0.0-rc, v4.0.0-rc.1 Apr 13, 2020
Signed-off-by: TXXT <hunterlxt@live.com>
Signed-off-by: TXXT <hunterlxt@live.com>
@hunterlxt hunterlxt self-assigned this Apr 22, 2020
@hunterlxt
Copy link
Member

/run-all-tests

Signed-off-by: TXXT <hunterlxt@live.com>
Signed-off-by: TXXT <hunterlxt@live.com>
@MyonKeminta
Copy link
Contributor

/merge

1 similar comment
@MyonKeminta
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 23, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 23, 2020

/run-all-tests

@sre-bot sre-bot merged commit a728a4f into tikv:release-4.0 Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/gRPC Component: gRPC status/can-merge Indicates a PR has been approved by a committer. type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants