Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: Use multi-batch-write for apply (#7111) #7718

Merged
merged 7 commits into from
May 14, 2020

Conversation

Little-Wallace
Copy link
Contributor

@Little-Wallace Little-Wallace commented Apr 30, 2020

Signed-off-by: Little-Wallace bupt2013211450@gmail.com

What problem does this PR solve?

Cherry-pick #7111

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • PR to update pingcap/tidb-ansible:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Improve write performance for batch-insert request.

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@Little-Wallace Little-Wallace added type/cherry-pick Type: PR - Cherry pick component/rocksdb Component: RocksDB engine labels Apr 30, 2020
@Little-Wallace Little-Wallace added this to the v4.0.0 milestone Apr 30, 2020
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@Little-Wallace
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiwu-arbug yiwu-arbug added the status/can-merge Indicates a PR has been approved by a committer. label May 1, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 1, 2020

Sorry @yiwu-arbug, you don't have permission to trigger auto merge event on this branch.

@yiwu-arbug yiwu-arbug removed the status/can-merge Indicates a PR has been approved by a committer. label May 1, 2020
@Little-Wallace
Copy link
Contributor Author

/run-integration-copr-test

@Little-Wallace Little-Wallace added the status/can-merge Indicates a PR has been approved by a committer. label May 1, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 1, 2020

Sorry @Little-Wallace, you don't have permission to trigger auto merge event on this branch.

@Little-Wallace
Copy link
Contributor Author

/run-all-tests

@Little-Wallace
Copy link
Contributor Author

/run-integration-tests

@glorv
Copy link
Contributor

glorv commented May 1, 2020

/run-integration-copr-test

1 similar comment
@glorv
Copy link
Contributor

glorv commented May 1, 2020

/run-integration-copr-test

@overvenus
Copy link
Member

It breaks Titan, please do not merge until it gets fixed.

@sre-bot
Copy link
Contributor

sre-bot commented May 14, 2020

@Little-Wallace
Copy link
Contributor Author

@overvenus The bug of Titan has been fixed and merged into release-4.0

@hicqu hicqu added this to the v4.0.0 milestone May 14, 2020
@hicqu
Copy link
Contributor

hicqu commented May 14, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 14, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 14, 2020

@Little-Wallace merge failed.

@hicqu
Copy link
Contributor

hicqu commented May 14, 2020

/run-all-tests

@hicqu hicqu merged commit 981ca2c into tikv:release-4.0 May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/rocksdb Component: RocksDB engine status/can-merge Indicates a PR has been approved by a committer. type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants