Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: mark peer as pending remove after destroying it (#7492) #7836

Merged
merged 1 commit into from
May 14, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 14, 2020

cherry-pick #7492 to release-4.0


Signed-off-by: 5kbpers tangminghua@pingcap.com

What problem does this PR solve?

Problem Summary:
If a peer was destroyed, the subsequent proposals should be neglected.

What is changed and how it works?

What's Changed:
Mark peer as pending_remove after destroying it.

Related changes

  • Need to cherry-pick to the release branch

Check List

  • Unit test
  • Integration test

Release note

  • Reject handling any request on a destroyed peer.

Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

/run-all-tests

@sre-bot sre-bot added sig/raft Component: Raft, RaftStore, etc. type/cherry-pick Type: PR - Cherry pick labels May 14, 2020
@sre-bot sre-bot added this to the v4.0.0-rc.2 milestone May 14, 2020
@MyonKeminta
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 14, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

/run-all-tests

@sre-bot sre-bot merged commit 035a1bf into tikv:release-4.0 May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/raft Component: Raft, RaftStore, etc. status/can-merge Indicates a PR has been approved by a committer. type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants