Revert "[PCP-21] Titan GC doesn’t affect online write (#121)" #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4dc4ba8. Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
force-pushed
the
revert-merge-rewrite
branch
from
ca38dd1
to
9f9080c
Compare
Signed-off-by: tabokie <xy.tao@outlook.com>
|
/test |
Signed-off-by: tabokie <xy.tao@outlook.com>
BusyJay
approved these changes
Jun 3, 2022
ti-srebot
approved these changes
Jun 6, 2022
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4dc4ba8.
gc_merge_rewritefeature is not GA-ed, and there's no good reason to use it afterlevel_merge. To make the situation worse, in newer versions of RocksDB, integrated BlobDB is more intertwined with merging logic, make this feature hard to maintain.Signed-off-by: tabokie xy.tao@outlook.com