Temp fix for data loss caused by concurrent flush #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Wu <yiwu@pingcap.com> wait flush before gc Signed-off-by: Yi Wu <yiwu@pingcap.com> Fix hot fix Signed-off-by: Yi Wu <yiwu@pingcap.com> change to flush_hotfix branch Signed-off-by: Yi Wu <yiwu@pingcap.com> update sync point name Signed-off-by: Yi Wu <yiwu@pingcap.com> also apply fix to TEST_StartGC Signed-off-by: Yi Wu <yiwu@pingcap.com> change to flush_hotfix_6.4 branch Signed-off-by: Yi Wu <yiwu@pingcap.com> update test Signed-off-by: Yi Wu <yiwu@pingcap.com>
|
Need to merge tikv/rocksdb#126 before merging this one. |
added 2 commits
October 16, 2019 03:05
Signed-off-by: Yi Wu <yiwu@pingcap.com>
|
Please merge latest master |
yiwu-arbug
pushed a commit
to yiwu-arbug/titan
that referenced
this pull request
Oct 16, 2019
Summary: Temporary fix for tikv#93. Fixing it by waiting until no flush is ongoing before starting a GC job. The drawback is GC can starve if flush runs so frequent that there's no gap between flush jobs. Test Plan: See the new test. The test will fail with "Corruption: Missing blob file" error before the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Temporary fix for #93. Fixing it by waiting until no flush is ongoing before starting a GC job. The drawback is GC can starve if flush runs so frequent that there's no gap between flush jobs.
Test Plan:
See the new test. The test will fail with "Corruption: Missing blob file" error before the fix.