Encode dynamic url segments when generating

tildeio · Apr 20, 2016 · 18012da · 18012da
1 parent 7ffd1de
commit 18012da
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/route-recognizer.js b/lib/route-recognizer.js
@@ -61,7 +61,7 @@ DynamicSegment.prototype = {
   },
 
   generate: function(params) {
-    return params[this.name];
+    return encodeURIComponent(params[this.name]);
   }
 };
 

diff --git a/tests/recognizer-tests.js b/tests/recognizer-tests.js
@@ -446,6 +446,14 @@ test("Generation works", function() {
   equal( router.generate("postIndex"), "/posts" );
 });
 
+test("Generation encodes dynamic segments", function() {
+  var postId = "abc/def";
+  var encodedPostId = encodeURIComponent(postId);
+  ok(postId !== encodedPostId, "precondition - encoded segment does not equal orginal segment");
+  equal( router.generate("post", { id: postId }), "/posts/" + encodedPostId );
+  equal( router.generate("edit_post", { id: postId }), "/posts/" + encodedPostId + "/edit" );
+});
+
 test("Parsing and generation results into the same input string", function() {
   var query = "filter%20data=date";
   equal(router.generateQueryString(router.parseQueryString(query)), '?' + query);
-Original file line number
+Diff line change
@@ Expand Up / @@ -61,7 +61,7 @@ DynamicSegment.prototype = { @@
       },
       generate: function(params) {
-        return params[this.name];
+        return encodeURIComponent(params[this.name]);
       }
     };
@@ Expand Down @@