Revert specificity changes in PR #46 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#103 also fixes this newly added test |
|
Closing in favor #103. |
|
#103 is broken. Reverting it. This should apply cleanly after the revert of #103 lands. @mixonic Can you:
(Or alternatively grant me access to your fork.) |
2 tasks
This patch causes regressions in real Ember code. Two reasons this might be the case: * This code causes specificity on a previous route to stomp on a later route. It expects the return value from `currentState.put` is always fresh, and thus that specificity can be set. In reality the return state object may be reused, so setting a new specificity would stomp an existing one. * This code does not take into account the depth of a segment added from a different route.
mixonic
force-pushed
the
specificity-fix
branch
from
8fd9c6e to
97f3bf6
Compare
|
@nathanhammond did the first, the second was unnecessary as the tests were already here 👏 Thank you for the regression test!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#46 changed the specificity system used in route-recognizer to be much simpler, however the simpler implementation also lost some behaviors expected be real-world Ember apps. This introduces a test for such a case as reported in emberjs/ember.js#13960 and rolls back the changes from #46.