Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Query param plus symbols (+) are now transformed to spaces #40

Merged
merged 1 commit into from
Jan 22, 2015

Conversation

jayphelps
Copy link
Contributor

Fixes emberjs/ember.js#10190

http://www.w3.org/TR/html401/interact/forms.html#h-17.13.4.1

Facebook's share redirect masking is a great way to confirm this issue and behavior. (note that even query keys can have encoded spaces)

Cc/ @machty

@rwjblue
Copy link
Collaborator

rwjblue commented Jan 16, 2015

LGTM.

@jayphelps
Copy link
Contributor Author

@rwjblue Anything needed for a merge? Wanna get this upstream asap.

machty added a commit that referenced this pull request Jan 22, 2015
[BUGFIX] Query param plus symbols (+) are now transformed to spaces
@machty machty merged commit 404b848 into tildeio:master Jan 22, 2015
@jayphelps
Copy link
Contributor Author

@machty thanks boo 💋

jayphelps added a commit to jayphelps/ember.js that referenced this pull request Jan 22, 2015
rwjblue added a commit to emberjs/ember.js that referenced this pull request Jan 22, 2015
rwjblue added a commit that referenced this pull request Jan 25, 2015
rwjblue pushed a commit to emberjs/ember.js that referenced this pull request Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

queryParams: pluses aren't converted to spaces
3 participants