Ensure transition.abort() works properly for query param only transitions.
#293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richgt
force-pushed
the
richgt/handle-aborted-qp-transition
branch
from
8da70ea
to
a4bb230
Compare
rwjblue
reviewed
Jul 17, 2020
Yup. In the plans, trying to work through figuring out if everything actually works first :-D. |
|
I think either a new test similar or a modification of this test would work: https://github.com/tildeio/router.js/blob/master/tests/router_test.ts#L1416-L1501 |
richgt
commented
Jul 19, 2020
| router.updateURL = function(updateUrl) { | ||
| url = updateUrl; | ||
| if (!initial) { | ||
| assert.ok(false, 'updateURL should not be called'); |
There was a problem hiding this comment.
@rwjblue - I was looking for something like currentURL(), but being in router.js, couldn't really find it, so this was the best I could come up with. If you have other ideas I'm certainly open. This does fail without the fix and pass with it.
richgt
force-pushed
the
richgt/handle-aborted-qp-transition
branch
from
1ef9a3b
to
3163b0d
Compare
rwjblue
requested changes
Jul 20, 2020
richgt
force-pushed
the
richgt/handle-aborted-qp-transition
branch
3 times, most recently
from
3a04795
to
68ca41e
Compare
rwjblue
reviewed
Jul 20, 2020
richgt
force-pushed
the
richgt/handle-aborted-qp-transition
branch
from
68ca41e
to
e2780dc
Compare
rwjblue
approved these changes
Jul 20, 2020
rwjblue
changed the title
transition.abort() works properly for query param only transitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emberjs/ember.js#18568