Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSVP 4.0 #261

Open
2 of 9 tasks
stefanpenner opened this issue Jun 28, 2014 · 17 comments
Open
2 of 9 tasks

RSVP 4.0 #261

stefanpenner opened this issue Jun 28, 2014 · 17 comments
Milestone

Comments

@stefanpenner
Copy link
Collaborator

stefanpenner commented Jun 28, 2014

checklist as time permits

  • drop helpers on RSVP namespace, all helpers that need the constructor for inheritance should end-up on Promise constructor
  • new AMD build
  • fast denodeify
  • drop cast
  • drop defer?
  • drop eventTarget
  • add reduce
  • error handler on by default
  • emit unhandled error stuff HostPromiseRejectionTracker #417
fivetanley pushed a commit that referenced this issue Aug 15, 2014
fivetanley pushed a commit that referenced this issue Aug 15, 2014
@H1D
Copy link

H1D commented Nov 3, 2014

why drop cast()?

@H1D
Copy link

H1D commented Nov 3, 2014

for future readers.
resolve() replaces cast()
#207

@stefanpenner
Copy link
Collaborator Author

i have removed 2 comments unrelated to this issue, and transfered the comments to #336

@stefanpenner stefanpenner added this to the 4.0.0 milestone Dec 8, 2014
@mphasize
Copy link

Hi, are there any plans for something like RSVP.map, .hash or .all with concurrency control?
I have a use case, where I need to make a number of calls to an API that is rate-limited and specifying the number of calls that are executed in parallel would help a lot. (Similar to https://github.com/petkaantonov/bluebird/blob/master/API.md#option-concurrency)

@stefanpenner
Copy link
Collaborator Author

Hi, are there any plans for something like RSVP.map, .hash or .all with concurrency control?
I have a use case, where I need to make a number of calls to an API that is rate-limited and specifying the number of calls that are executed in parallel would help a lot. (Similar to https://github.com/petkaantonov/bluebird/blob/master/API.md#option-concurrency)

their are no such plans currently.

@mphasize
Copy link

Thanks for clarifying, good to know. :)

@bekzod
Copy link
Contributor

bekzod commented May 17, 2017

maybe also drop old IE support ?

@stefanpenner
Copy link
Collaborator Author

maybe also drop old IE support ?

How old do you think?

@bekzod
Copy link
Contributor

bekzod commented May 17, 2017

below IE9 no ?

@bekzod
Copy link
Contributor

bekzod commented May 18, 2017

can I take drop helpers on RSVP namespace... ?

@bekzod
Copy link
Contributor

bekzod commented May 18, 2017

it is also good idea to drop option to pass promise to RSVP.filter because in others helpers RSVP.map and RSVP.filter you just pass array (you cannot pass promise), so it is not uniform

@bekzod bekzod mentioned this issue May 18, 2017
@stefanpenner
Copy link
Collaborator Author

can I take drop helpers on RSVP namespace... ?

sure, but we may need an upgrade transition path (so a quick guide, and maybe a compat shim) for some. At-least for ember users

@bekzod
Copy link
Contributor

bekzod commented Jun 6, 2017

also adding .return(val) helper (alias to .then(()=> val)) would super helpful

@stefanpenner
Copy link
Collaborator Author

also adding .return(val) helper (alias to .then(()=> val)) would super helpful

I think i would prefer to have a second module, something like rsvp-party for such extra additions. Adding things to promise.prototype that isn't in the spec, or isn't destined for the spec is a tad risky IMHO.

@bekzod
Copy link
Contributor

bekzod commented Jul 17, 2017

@stefanpenner when we will start merge for 4.0.0 :P ? maybe we just integrate compat shim to ember core and just deprecate stuff from there, and for others we can write up transition guide ? thoughts

@bekzod
Copy link
Contributor

bekzod commented Jul 17, 2017

or we can move namespace changes and dropping things to 5.0.0, and in 4.0.0 drop es5 fallbacks, add reduce, add eager map/filter/reduce so it be seamless upgrade

@bekzod
Copy link
Contributor

bekzod commented Jul 20, 2017

should we also drop rethrow not seeing it being used anywhere :P ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants