-
Notifications
You must be signed in to change notification settings - Fork 333
[FFI] Use tvm ffi as the default execution backend #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
6745eac
[Refactor] Update FFI type handling and simplify argument management
LeiWang1999 b09d6d7
[Update] Sync TVM submodule and enhance kernel source handling
LeiWang1999 dacab10
[Refactor] Clean up imports and improve code formatting
LeiWang1999 ca91aa8
Merge branch 'main' of https://github.com/tile-ai/tilelang into ffi_1114
LeiWang1999 c6812f1
Update execution backend options and improve resolution logic
LeiWang1999 d09b267
lint fix
LeiWang1999 4a6e99b
fix
LeiWang1999 1ee9132
Enhance argument handling in CUDA and HIP runtime modules
LeiWang1999 4364065
lint fix
LeiWang1999 a555165
lint fix
LeiWang1999 2f0bf8d
lint fix
LeiWang1999 8f59fa1
lint fix
LeiWang1999 0df9ba4
minor fix
LeiWang1999 e202d38
fix
LeiWang1999 72fff54
recover check
LeiWang1999 3b30b19
Refactor argument binding and validation in `arg_binder.cc`
LeiWang1999 f85bb8f
lint fix
LeiWang1999 65448b5
stride fix
LeiWang1999 f2f8a28
minor fix
LeiWang1999 0794c29
fix
LeiWang1999 2b3bd54
lint fix
LeiWang1999 7fdfa12
lint fix
LeiWang1999 f177025
Add CUDA stream access policy window helpers and integrate with L2 pe…
LeiWang1999 0694198
check with symbolic
LeiWang1999 f13aecd
support null ptr
LeiWang1999 7165251
Update CMakeLists and lower.py for code generation and subproject status
LeiWang1999 2e6f110
lint fix
LeiWang1999 8d748ba
Merge branch 'main' of https://github.com/tile-ai/tilelang into ffi_1114
LeiWang1999 7c0b8cd
Update comments for clarity in quickstart.py
LeiWang1999 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule tvm
updated
from 093b2c to f4105f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify CUDA version requirements for stream access policy window APIs.
The new constants
tvm_cuda_stream_set_access_policy_windowandtvm_cuda_stream_reset_access_policy_windoware declared outside the#if (CUDA_MAJOR_VERSION >= 12)guard (lines 13-18), unlike the TMA descriptor constants above them. Ensure this is intentional and that the CUDA stream access policy window APIs (cuStreamSetAttributewithCU_STREAM_ATTRIBUTE_ACCESS_POLICY_WINDOW,cuCtxSetLimit,cuCtxResetPersistingL2Cache) are available in CUDA versions prior to 12.🌐 Web query:
💡 Result:
The stream "access policy window" (cudaStreamAttributeAccessPolicyWindow / accessPolicyWindow used with cudaStreamSetAttribute / cuLaunchAttribute) was introduced in CUDA 11.0 (documented in the CUDA 11 features announcement and in the CUDA Programming Guide). [1][2]
Sources:
Add CUDA version guard for stream access policy window constants.
The stream access policy window APIs were introduced in CUDA 11.0, but the constants
tvm_cuda_stream_set_access_policy_windowandtvm_cuda_stream_reset_access_policy_window(lines 20–24) lack any version guard. They should be wrapped with#if (CUDA_MAJOR_VERSION >= 11)to prevent use in earlier CUDA versions where these APIs are unavailable.🤖 Prompt for AI Agents