Skip to content

[Refactor] Update KernelLaunch to clarify block name #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeiWang1999 merged 1 commit into from
Apr 27, 2025
Merged

[Refactor] Update KernelLaunch to clarify block name #441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/ir.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ KernelLaunchFrame KernelLaunch(Array<PrimExpr> grid_size,
attrs.defined() && attrs.count(tilelang_is_cpu_kernel_frame);

if (is_cpu_kernel_frame) {
// Launch CPU Kernel
ICHECK(grid_size.size() >= 0);
ICHECK(block_size.size() == 0) << "CPU kernel cannot have block size";
ICHECK(attrs.defined());
Expand All @@ -170,7 +171,6 @@ KernelLaunchFrame KernelLaunch(Array<PrimExpr> grid_size,
n->frames.push_back(
MakeIterVarFrame("block_var_" + std::to_string(i), grid_size[i]));
}
// Launch CPU Kernel
} else {
// Launch GPU Kernel
ICHECK(grid_size.size() <= 3);
Expand Down Expand Up @@ -203,17 +203,15 @@ KernelLaunchFrame KernelLaunch(Array<PrimExpr> grid_size,
CreateEnvThread("tz", "threadIdx.z", block_size[2].dtype()),
block_size[2]));
}
} else {
n->frames.push_back(Block(""));
}
}

if (attrs.defined()) {
auto empty_block = Block("");
auto empty_block = Block("root");
empty_block->annotations = attrs;
n->frames.push_back(empty_block);
} else {
n->frames.push_back(Block(""));
n->frames.push_back(Block("root"));
}

return KernelLaunchFrame(n);
Expand Down
Loading