[Bugfix] Check CUDA target before checking for TMA #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeiWang1999
approved these changes
May 11, 2025
lucifer1004
pushed a commit
to lucifer1004/tilelang
that referenced
this pull request
May 16, 2025
LeiWang1999
pushed a commit
to LeiWang1999/tilelang
that referenced
this pull request
Jul 18, 2025
LeiWang1999
pushed a commit
to LeiWang1999/tilelang
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #477,
have_tma(target)calls will return error if target is not CUDA. Hence, this PR adds an additional check before callinghave_tma().Another approach is to put CUDA target check inside
have_tma()instead.@LeiWang1999