Skip to content

Conversation

@xwhzz
Copy link
Contributor

@xwhzz xwhzz commented Jul 28, 2025

No description provided.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run bash format.sh in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work!

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @xwhzz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the continuous integration (CI) pipeline's formatting check by removing a manual intervention step. The change allows the CI system to proceed without user interaction when files are reformatted, paving the way for automated commits of style changes.

Highlights

  • CI Workflow Streamlining: I've modified the format.sh script to remove the conditional block that previously caused the script to exit and prompt users to manually review and stage reformatted files. This streamlines the CI formatting process.
  • Enabling Automated Formatting Commits: By removing the exit 1 condition when files are reformatted, this change is a crucial step towards enabling the CI pipeline to automatically commit formatting changes, aligning with the pull request's stated goal.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up the format.sh script by removing a duplicated code block. My review highlights a potential mismatch between the PR's title, which suggests automating commits of formatting changes, and the script's actual behavior, which still fails the CI build on such changes. I've recommended either updating the script's logic to perform commits or updating the PR title to accurately reflect the cleanup work.

@xwhzz xwhzz force-pushed the ci branch 4 times, most recently from fcf0b27 to 1a5753d Compare July 28, 2025 11:46
@LeiWang1999 LeiWang1999 merged commit 562796e into tile-ai:main Jul 29, 2025
1 check passed
@xwhzz xwhzz deleted the ci branch August 11, 2025 10:18
RubiaCx pushed a commit to RubiaCx/tilelang that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants