-
Notifications
You must be signed in to change notification settings - Fork 333
[Carver] Remove legacy todo items in carver's readme #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate CUDA type printing for better clarity
…consistency and clarity; add apply_simplify function to simplify PrimFunc or IRModule.
…remove unnecessary whitespace in multiple files.
…to use 'tilelang.language' for consistency
…_tilelang_kernel_gemm_mma_intrinsic.py
…r result validation in test_tilelang_kernel_gemm_mma_intrinsic.py
…at Peking University
…riting high-performance kernels with thread primitives
…ormatting in layout and test files
…ameter formatting
… for improved code documentation and clarity
…for improved readability
…roved readability
…r_recommend_hints for improved readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new features and improvements to the
tilelanglibrary, with a focus on enhancing the carver module's functionality and adding support for new templates. The most important changes include adding new test cases, incorporating theFlashAttentionTemplate, and updating the node and policy classes to support more complex operations.New Features and Enhancements:
testing/python/carver/test_tilelang_carver_generate_hints.pyandtesting/python/carver/test_tilelang_carver_recommend_hints.py. [1] [2]FlashAttentionTemplatefor attention-like operations with flash memory in thetilelang/carvermodule. [1] [2]README.mdto document the newFlashAttentionTemplateand removed the TODO item for Flash Attention support.Codebase Simplification and Refactoring:
PrimFuncNodeclass and addedOutputNodeandEdgeclasses to support more complex graph structures intilelang/carver/roller/node.py. [1] [2] [3] [4] [5] [6]DefaultPolicyclass to use the new node classes and support multiple output nodes intilelang/carver/roller/policy/default.py. [1] [2] [3]Minor Fixes:
tilelang/carver/roller/bestfit.pyto improve memory allocation logic.get_rstepmethod intilelang/carver/roller/hint.pyto properly map reduce steps to nodes.