Skip to content

[BugFix] Refactor the op check in LowerTileOp pass using the member function instead of string match #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2025
Merged

[BugFix] Refactor the op check in LowerTileOp pass using the member function instead of string match #771

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95db585
[BugFix] Refactor the op check in LowerTileOp pass using the member f…
tzj-fxz Aug 31, 2025
3efd812
[Lint]
tzj-fxz Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/transform/lower_tile_op.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
#include "../layout/layout.h"
#include "../layout/utils.h"
#include "../op/builtin.h"
#include "../op/gemm.h"
#include "../op/gemm_sp.h"
#include "../op/operator.h"

#include "arith/ir_mutator_with_analyzer.h"
Expand Down Expand Up @@ -84,7 +86,7 @@ class BufferGemmCollector : public StmtExprVisitor {
private:
void VisitStmt_(const EvaluateNode *op) {
auto call = Downcast<Call>(op->value);
if (call->op.same_as(Op::Get("tl.gemm"))) {
if (call->op.same_as(Gemm::Get())) {
auto srcA_buffer_access_ptr = Downcast<Call>(call->args[0]);
ICHECK(srcA_buffer_access_ptr->op.same_as(builtin::tvm_access_ptr()));
auto srcA_buffer_var = Downcast<Var>(srcA_buffer_access_ptr->args[1]);
Expand All @@ -97,7 +99,7 @@ class BufferGemmCollector : public StmtExprVisitor {
buffer_var_gemm_.push_back(srcA_buffer_var);
buffer_var_gemm_.push_back(srcB_buffer_var);
buffer_var_gemm_.push_back(dst_buffer_var);
} else if (call->op.same_as(Op::Get("tl.gemm_sp"))) {
} else if (call->op.same_as(GemmSP::Get())) {
auto srcA_buffer_access_ptr = Downcast<Call>(call->args[0]);
ICHECK(srcA_buffer_access_ptr->op.same_as(builtin::tvm_access_ptr()));
auto srcA_buffer_var = Downcast<Var>(srcA_buffer_access_ptr->args[1]);
Expand Down