Skip to content

Conversation

@LeiWang1999
Copy link
Member

@LeiWang1999 LeiWang1999 commented Sep 15, 2025

Summary by CodeRabbit

  • Build Configuration

    • Added global static linking flags for gcc and g++ libraries
    • Bumped project version from 0.1.5 to 0.1.6
  • Development Environment

    • Updated Dockerfile to include Python 3.8 conda environment
    • Added symlink for Python 3.8 installation

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 15, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds unconditional static libgcc/libstdc++ flags to global C/C++ compile flags in CMakeLists.txt, increments VERSION from 0.1.5 to 0.1.6, and updates maint/scripts/pypi.Dockerfile to create a Python 3.8 conda environment with a corresponding symlink alongside existing Python versions.

Changes

Cohort / File(s) Summary
Build flags (CMake)
CMakeLists.txt
Appends -static-libgcc and -static-libstdc++ to CMAKE_C_FLAGS and CMAKE_CXX_FLAGS unconditionally; existing per-target static linking logic remains.
Packaging (PyPI Dockerfile)
maint/scripts/pypi.Dockerfile
Adds conda env py38 and symlink /usr/bin/python3.8 to the env’s python; retains existing py39–py312 setups.
Release versioning
VERSION
Bumps version from 0.1.5 to 0.1.6.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

A toggle here, a flag made tight,
I hop through CMake’s moonlit night.
New py38 joins the crew—how neat!
Version bumps with gentle feet.
With static links and tidy brew,
This bunny ships a build that’s true. 🐇✨

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 094e229 and 8385470.

📒 Files selected for processing (3)
  • CMakeLists.txt (1 hunks)
  • VERSION (1 hunks)
  • maint/scripts/pypi.Dockerfile (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run bash format.sh in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work!

🚀

- Added static linking flags for GCC and libstdc++ in CMakeLists.txt to enhance library linking.
- Removed the cmake version requirement from pyproject.toml to allow for broader compatibility.
- Updated the tox command in the Docker distribution script to include Python 3.8 for testing environments.
- Changed Python version requirement in README.md from 3.9+ to 3.8+.
- Updated installation and testing scripts to use Python 3.8 instead of 3.9, ensuring compatibility with the new minimum version.
- Adjusted tox commands in local and PyPI distribution scripts to include Python 3.8 in the testing environments.
…ect.toml

- Added CMake version requirement (>=3.26) to pyproject.toml for build compatibility.
- Created a Python 3.8 environment in the Dockerfile and added a symlink for easier access to the Python 3.8 executable.
@LeiWang1999 LeiWang1999 marked this pull request as ready for review September 19, 2025 15:15
@LeiWang1999 LeiWang1999 merged commit 1ad6e46 into tile-ai:main Sep 19, 2025
2 of 4 checks passed
RubiaCx pushed a commit to RubiaCx/tilelang that referenced this pull request Nov 24, 2025
* bump version to 0.1.6

* phaseout py38

* py39

* Update submodule 'tvm' to latest commit adc0e48

* [Build] Update CMake and Python environment settings

- Added static linking flags for GCC and libstdc++ in CMakeLists.txt to enhance library linking.
- Removed the cmake version requirement from pyproject.toml to allow for broader compatibility.
- Updated the tox command in the Docker distribution script to include Python 3.8 for testing environments.

* [Build] Update Python version requirements in scripts and documentation

- Changed Python version requirement in README.md from 3.9+ to 3.8+.
- Updated installation and testing scripts to use Python 3.8 instead of 3.9, ensuring compatibility with the new minimum version.
- Adjusted tox commands in local and PyPI distribution scripts to include Python 3.8 in the testing environments.

* [Build] Update Python and CMake requirements in Dockerfile and pyproject.toml

- Added CMake version requirement (>=3.26) to pyproject.toml for build compatibility.
- Created a Python 3.8 environment in the Dockerfile and added a symlink for easier access to the Python 3.8 executable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant