Skip to content

[Bugfix] Bug fix when git command is not installed #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
Merged

[Bugfix] Bug fix when git command is not installed #823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tilelang/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ def get_git_commit_id() -> Union[str, None]:
cwd=os.path.dirname(os.path.abspath(__file__)),
stderr=subprocess.DEVNULL,
encoding='utf-8').strip()
except subprocess.SubprocessError:
# FileNotFoundError is raised when git is not installed
except (subprocess.SubprocessError, FileNotFoundError):
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly fixes the bug, it's a good practice to catch more specific exceptions. subprocess.SubprocessError is a general base class. The most likely error here, besides FileNotFoundError, is subprocess.CalledProcessError, which is raised when the command returns a non-zero exit code (e.g., if the directory is not a git repository). Using subprocess.CalledProcessError makes the error handling more precise and the code's intent clearer.

Suggested change
except (subprocess.SubprocessError, FileNotFoundError):
except (subprocess.CalledProcessError, FileNotFoundError):

return None


Expand Down