[Bugfix] Skip fp4 dtype binding when using older versions of ml_dtypes

[LeiWang1999]

Summary by CodeRabbit

• New Features

  • None.

• Bug Fixes

  • Prevented errors during version retrieval when Git is unavailable, ensuring the app runs smoothly in environments without Git. Version still includes the commit ID when available.

• Chores

  • Updated third-party TVM dependency to a newer revision.

[coderabbitai]

Walkthrough

Updated the 3rdparty/tvm submodule to a new commit. Adjusted tilelang/version.py so get_git_commit_id now also handles FileNotFoundError alongside SubprocessError, returning None when git is unavailable. No public API signatures changed.

Changes

Cohort / File(s)	Summary
Submodule update: TVM 3rdparty/tvm	Submodule pointer advanced from 87b845f to 9d467c8; no direct code changes in this repo’s files or public APIs.
Version retrieval robustness tilelang/version.py	get_git_commit_id now catches both subprocess.SubprocessError and FileNotFoundError, returning None if git is missing or command fails; version string appending behavior unchanged.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant App as App
  participant Version as version.py
  participant Git as git (external)

  App->>Version: get_git_commit_id()
  alt git available and succeeds
    Version->>Git: invoke `git` to get commit id
    Git-->>Version: commit hash
    Version-->>App: commit hash
  else git missing or fails
    Note right of Version: Catches SubprocessError or FileNotFoundError
    Version-->>App: None
  end

  App->>Version: build __version__
  Note over App,Version: Append commit id to __version__ only if available

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitched my whiskers, sniffed the trail,
A submodule hop—no code to hail.
In version burrow, safer digs:
If git is gone, no panic jigs.
I stamp my paws, the build stays bright—
Hash if present, none’s alright. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title Check	⚠️ Warning	The title claims the PR "skips fp4 dtype binding when using older versions of ml_dtypes", but the provided diff only updates a 3rdparty/tvm submodule pointer and adds error handling in tilelang/version.py; there are no changes touching dtype bindings or ml_dtypes usage. Because the title describes behaviour not present in the changeset, it is misleading and does not accurately summarize the main change. This will confuse reviewers and the project history.	Rename the PR to match the actual changes (e.g., "Update 3rdparty/tvm submodule and make get_git_commit_id robust when git is unavailable") or add the intended fp4/ml_dtypes changes to this branch and update the PR description to explain them; ensure the title concisely reflects the primary change so reviewers can verify the fix.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run bash format.sh in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work!

🚀

[gemini-code-assist]

Summary of Changes

Hello @LeiWang1999, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily addresses a compatibility issue by updating the 3rdparty/tvm submodule, which is intended to skip fp4 dtype binding when older versions of ml_dtypes are in use. Additionally, it improves the robustness of the get_git_commit_id utility function by gracefully handling cases where the git command is not found, preventing potential crashes in such environments.

Highlights

• TVM Submodule Update: The 3rdparty/tvm submodule has been updated to a newer commit (9d467c89ec1ddf997ed1abb75c5e03883396f1fd). This update is expected to include the fix for skipping fp4 dtype binding when using older ml_dtypes versions, as indicated by the pull request title.
• Robust Git Commit ID Retrieval: The tilelang/version.py file now includes FileNotFoundError in its exception handling for subprocess.SubprocessError. This makes the get_git_commit_id function more robust by gracefully handling scenarios where the git command-line tool might not be installed on the system.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request primarily updates the tvm submodule, which, as the title suggests, is likely to fix a bug related to fp4 dtype binding with older versions of ml_dtypes. Additionally, there's a bugfix in tilelang/version.py to handle scenarios where git is not installed by catching FileNotFoundError. This makes the version retrieval logic more robust. The changes are sound and improve the project's stability.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

tilelang/version.py (1)

31-37: Solid fix; optionally catch OSError and reuse current_dir.

Catching OSError covers FileNotFoundError, NotADirectoryError, and PermissionError, hardening imports in edge packaging/env cases. Also reuse current_dir to avoid duplicate path resolution.

-        return subprocess.check_output(['git', 'rev-parse', 'HEAD'],
-                                       cwd=os.path.dirname(os.path.abspath(__file__)),
+        return subprocess.check_output(['git', 'rev-parse', 'HEAD'],
+                                       cwd=current_dir,
                                        stderr=subprocess.DEVNULL,
                                        encoding='utf-8').strip()
-    # FileNotFoundError is raised when git is not installed
-    except (subprocess.SubprocessError, FileNotFoundError):
+    # OSError covers FileNotFoundError (git missing), NotADirectoryError, PermissionError
+    except (subprocess.SubprocessError, OSError):
         return None

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1547995 and 0ae3f40.

📒 Files selected for processing (2)

• 3rdparty/tvm (1 hunks)
• tilelang/version.py (1 hunks)

🔇 Additional comments (1)

3rdparty/tvm (1)

1-1: Submodule bump — verify dtype-only guard fix and CI coverage for ml_dtypes

Upstream compare (TileLang/tvm): 1 commit; changed file: python/tvm/ffi/dtype.py. OLD_SHA=b56420b34277b6e257b0426eb78ecec1f1fb45fb → NEW_SHA=9d467c89ec1ddf997ed1abb75c5e03883396f1fd.

• Verify the commit is strictly a guard/bugfix in python/tvm/ffi/dtype.py and does not introduce new public TVM symbols or API/ABI changes our code relies on (inspect the patch/diff).
• Ensure CI covers: an affected older ml_dtypes version (e.g., <0.5 or the minimal impacted version), the latest ml_dtypes, and test runs both with and without the TVM runtime.
• If uncertainty remains, attach the upstream diff/commit or run: gh api /repos/TileLang/tvm/compare/b56420b34277b6e257b0426eb78ecec1f1fb45fb...9d467c89ec1ddf997ed1abb75c5e03883396f1fd | jq '.files[] | {filename,status,patch}' to confirm no new symbols/API were added.