[Analyzer] Enhance ConstIntBoundAnalyzer and IntervalSet with modular set analysis

[LeiWang1999]

• Added modular set analysis to ConstIntBoundAnalyzer for tighter bounds when min_value equals max_value.
• Introduced ComputeGCD function to calculate the GCD of two integers.
• Updated Combine functions in IntervalSet to accept operation nodes for better type handling.
• Enhanced tests for modular set bounds in both const integer bounds and interval sets.

Now we can prove:

class TestModularSetBound(BaseCompare):
    analyzer = tvm.arith.Analyzer()
    tx = tvm.te.var("tx", dtype="int32")
    bx = tvm.te.var("bx", dtype="int32")

    expr = (bx * 2048 + tx * 16) % 7168

    test_case = tvm.testing.parameter(
        TestCase(expr, (0, 7152), {bx: (0, 3584), tx: (0, 128)}),
    )

and

ck = IntSetChecker()
x = tvm.te.var("x", dtype="int32")
y = tvm.te.var("y", dtype="int32")
expr = (x * 2048 + y * 16) % 7168
ck.verify(
    expr, {x: tvm.arith.IntervalSet(0, 128), y: tvm.arith.IntervalSet(0, 3584)}, (0, 7152)
)

Summary by CodeRabbit

• Chores
  • Updated a third-party machine learning compiler dependency to the latest upstream revision for alignment with the ecosystem.
  • No user-facing or functional changes; behavior and interfaces remain unchanged.
  • Improves long-term compatibility and maintainability without impacting current workflows.
  • No action required from users or administrators.

[coderabbitai]

Walkthrough

Updated the 3rdparty/tvm submodule reference from commit 6051f6d to 0506337. No functional code changes and no public declarations modified.

Changes

Cohort / File(s)	Summary
Submodule update 3rdparty/tvm	Advance submodule pointer from 6051f6d to 0506337; no code changes within this repo.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nudge a pointer, hop and grin,
A tiny shift, a subtle win.
No code to chew, no lines to mend,
Just tracks updated end-to-end.
Commit crumbs lead where I have been—
The trail is tidy, carrot-clean.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "[Analyzer] Enhance ConstIntBoundAnalyzer and IntervalSet with modular set analysis" accurately and concisely captures the primary intent described in the PR objectives—adding modular-set analysis, ComputeGCD, updating Combine functions, and related tests to tighten bounds; it is specific and readable for teammates scanning history. The raw file-level summary only notes a tvm submodule update, but the PR description clarifies substantive analyzer changes, so the title is directly related to the main change. The bracketed scope "[Analyzer]" is a helpful prefix that makes the change’s area clear.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ad6e46 and da1cf0c.

📒 Files selected for processing (1)

• 3rdparty/tvm (1 hunks)

🔇 Additional comments (1)

3rdparty/tvm (1)

1-1: Submodule bump to TVM (0506337…): verify Analyzer.modular_set + IntervalSet Combine changes and run targeted tests / API checks before merge.

Local probe confirms the upstream commit adds modular_set wiring to Analyzer and op‑specific IntervalSet Combine logic (affects arith/*, TIR transforms, and codegen). Take these actions before merging:

• Run/extend unit + integration tests that assert tightened ConstIntBoundAnalyzer bounds and IntervalSet Combine behavior (example check: verify (bx2048+tx16)%7168 ∈ [0,7152] with bx∈[0,3584], tx∈[0,128] via tvm.arith.Analyzer).
• Audit ABI/FFI and callsites used by tilelang: 3rdparty/tvm/src/arith/analyzer.cc (modular_set wiring, FFI registration ~lines 282–287), 3rdparty/tvm/src/arith/const_int_bound.cc (GCD/Tightening logic ~285–356), 3rdparty/tvm/src/arith/int_set.cc (Combine/Mod/FloorMod logic ~116–140, ~236–369; FFI methods ~1252–1255), and TIR/codegen call sites (storage_rewrite.cc ~1122–1496, loop_partition.cc ~474–671, target/llvm/codegen_llvm.cc ~719–721, target/source/codegen_c.cc ~818–822).
• Run performance/regression suites and inspect the submodule diff for any license changes.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run bash format.sh in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work!

🚀

[gemini-code-assist]

Summary of Changes

Hello @LeiWang1999, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the arithmetic analysis capabilities within TVM by introducing modular set analysis to the ConstIntBoundAnalyzer and IntervalSet. The core objective is to enable the system to derive much tighter and more accurate integer bounds, particularly for expressions involving modulo operations. This is achieved through the addition of a ComputeGCD utility and updates to IntervalSet's Combine functions to better handle operation nodes, all backed by new tests demonstrating the improved precision. The changes are incorporated via an update to the 3rdparty/tvm submodule.

Highlights

• Modular Set Analysis: Integrated modular set analysis into ConstIntBoundAnalyzer to achieve tighter bounds, especially when min_value and max_value are equal, improving precision in arithmetic analysis.
• GCD Functionality: Introduced a new ComputeGCD function, a utility for calculating the greatest common divisor of two integers, which supports the enhanced modular analysis.
• IntervalSet Enhancements: Updated Combine functions within IntervalSet to now accept operation nodes, allowing for more robust and type-aware handling of arithmetic operations.
• Testing Improvements: Added comprehensive tests specifically for modular set bounds, validating the correctness and effectiveness of the new analysis capabilities in both constant integer bounds and interval sets.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the TVM submodule to a new commit. The description indicates that this update enhances the ConstIntBoundAnalyzer and IntervalSet with modular set analysis, which should lead to tighter arithmetic bounds. These changes appear beneficial. However, the provided diff only shows the submodule hash update, making a detailed code review of the actual implementation within the submodule impossible. Assuming the submodule changes have been properly reviewed and tested in their own repository, this update is appropriate.