-
Notifications
You must be signed in to change notification settings - Fork 333
[CI] Fix documentation runner by adding 'nvidia' tag #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe GitHub Actions workflow for docs publishing was updated to expand the runner labels from "self-hosted" to "[self-hosted, nvidia]". No other steps, jobs, or conditions were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
👋 Hi! Thank you for contributing to the TileLang project. Please remember to run We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/publish_docs.yml (2)
9-11: Tighten default permissions.You’re pushing to another repo via a PAT in the URL; contents: write for this repo isn’t required. Prefer least privilege:
permissions: - contents: write + contents: read
3-8: Optional: simplify trigger to a push on main.Since you only run after merge to main, a push trigger reduces pull_request_target complexity:
-on: - pull_request_target: - types: [closed] - workflow_dispatch: +on: + push: + branches: [main] + workflow_dispatch: - if: ${{ github.event.pull_request.merged == true && github.event_pull_request.base.ref == 'main' }} || ${{ github.event_name == 'workflow_dispatch' }} + # No conditional needed when using pushKeep as-is if you rely on closed PR metadata; otherwise this is simpler and safer.
Also applies to: 14-14
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/publish_docs.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/publish_docs.yml
15-15: label "nvidia" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-test-amd
- GitHub Check: bot-task
🔇 Additional comments (1)
.github/workflows/publish_docs.yml (1)
15-15: Verify self-hosted runner labels and actionlint configThe
gh apicall returned a 403 error. Please manually confirm that your self-hosted runner is labeled with bothself-hostedandnvidia, and add or update an.actionlint.yamlfile to allow thenvidialabel.
Summary by CodeRabbit