Skip to content

Conversation

@xwhzz
Copy link
Contributor

@xwhzz xwhzz commented Oct 1, 2025

Summary by CodeRabbit

  • Chores
    • Updated the documentation publishing workflow’s runner configuration to support an additional self-hosted label, broadening compatibility with available runners.
    • No changes to workflow steps, logic, or conditions.
    • No impact on application features or behavior; this is an infrastructure configuration update only.
    • End-users will not see any functional differences from this change.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 1, 2025

Walkthrough

The GitHub Actions workflow for docs publishing was updated to expand the runner labels from "self-hosted" to "[self-hosted, nvidia]". No other steps, jobs, or conditions were changed.

Changes

Cohort / File(s) Change Summary
CI workflow runner labels
`.github/workflows/publish_docs.yml`
Updated runs-on to include [self-hosted, nvidia]; no other workflow logic modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nudge the gears, a subtle spin,
New runner waits with GPU grin.
Docs will bloom on faster ground,
Self-hosted paws, NVIDIA found.
Thump-thump—pipelines hop along,
A rabbit hums a build-time song.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly describes the primary change of the workflow runner configuration by specifying the addition of the 'nvidia' tag and clearly indicates its relation to the CI documentation process without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Oct 1, 2025

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run bash format.sh in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work!

🚀

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/publish_docs.yml (2)

9-11: Tighten default permissions.

You’re pushing to another repo via a PAT in the URL; contents: write for this repo isn’t required. Prefer least privilege:

 permissions:
-  contents: write
+  contents: read

3-8: Optional: simplify trigger to a push on main.

Since you only run after merge to main, a push trigger reduces pull_request_target complexity:

-on:
-  pull_request_target:
-    types: [closed]
-  workflow_dispatch:
+on:
+  push:
+    branches: [main]
+  workflow_dispatch:
-    if: ${{ github.event.pull_request.merged == true && github.event_pull_request.base.ref == 'main' }} || ${{ github.event_name == 'workflow_dispatch' }}
+    # No conditional needed when using push

Keep as-is if you rely on closed PR metadata; otherwise this is simpler and safer.

Also applies to: 14-14

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d38297 and dd91cfe.

📒 Files selected for processing (1)
  • .github/workflows/publish_docs.yml (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/publish_docs.yml

15-15: label "nvidia" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-test-amd
  • GitHub Check: bot-task
🔇 Additional comments (1)
.github/workflows/publish_docs.yml (1)

15-15: Verify self-hosted runner labels and actionlint config

The gh api call returned a 403 error. Please manually confirm that your self-hosted runner is labeled with both self-hosted and nvidia, and add or update an .actionlint.yaml file to allow the nvidia label.

@LeiWang1999 LeiWang1999 merged commit f09e91e into tile-ai:main Oct 1, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants