Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of GHA instead of Travis #116

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Usage of GHA instead of Travis #116

merged 1 commit into from
Dec 20, 2022

Conversation

benoit9126
Copy link
Contributor

Another part of #114

@benoit9126
Copy link
Contributor Author

Is this repository still maintained? #113 starts to be really annoying as some other dependencies that I have in my project now depend on protobuf>=4.21

Copy link
Member

@rmarianski rmarianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this repository still maintained?

apologies, haven't been responsive here as of late. Thanks for the work to help move this forward 🙇

I'm generally supportive of all your suggested changes. I'd prefer to first confirm that we're ok with dropping python 2, and then we can merge that in. Following that, it'd be great if you could continue splitting off the changes you made in #114 into smaller prs.

@benoit9126
Copy link
Contributor Author

@rmarianski Great! I can continue with additional PR after merging the two first #115 and #116

@rmarianski rmarianski merged commit 4be0296 into tilezen:master Dec 20, 2022
@rmarianski
Copy link
Member

@rmarianski Great! I can continue with additional PR after merging the two first #115 and #116

haven't heard any objections, and I went ahead and merged those prs. Thanks again 🙇

@benoit9126 benoit9126 deleted the github-actions branch December 20, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants