Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #122

Merged
merged 7 commits into from
Dec 21, 2022
Merged

Improvements #122

merged 7 commits into from
Dec 21, 2022

Conversation

benoit9126
Copy link
Contributor

I continue with this PR to:

  • Rename methods which does not have a Pythonic name
  • Use pre-commit on the setup.py file (failed pre-commit GHA run)
  • Delete the possibility to pass a round function as there is no more problems with Python 2
  • Factorize some useful functions and constants in a new utils.py file
  • A lot of methods could be changed into static- or class-methods
  • Update the status badge in the README file

@coveralls
Copy link

coveralls commented Dec 21, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 76.587% when pulling b809658 on benoit9126:improvements into 066d665 on tilezen:master.

rmarianski
rmarianski approved these changes Dec 21, 2022
View reviewed changes
mapbox_vector_tile/polygon.py Show resolved Hide resolved
@rmarianski rmarianski merged commit 182f243 into tilezen:master Dec 21, 2022
@benoit9126 benoit9126 deleted the improvements branch December 22, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmarianski rmarianski rmarianski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benoit9126 @coveralls @rmarianski