-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.10.x and stealth add v2 features #267
base: main
Are you sure you want to change the base?
Conversation
* Change in header de-duplication * enforce utf8 encoding * more code refactoring
* restructure tests * improve tests
Thanks @tilo! A couple of questions regarding this (I have not yet looked at the changes):
|
@mscrivo This PR is still WIP, so I'm not making promises to be 100% compatible with 2.0-pre, but I'll try. Because the change from v1.x to v2.x could be disruptive to users, I decided to add both code versions to main for now, and switch them via the Eventually the 1.x code will be deprecated and removed. |
with old count_quote_cards:time: 10.101 ms allocated memory by class
allocated objects by gem
allocated objects by class
with new count_quote_chars:time: 6.043 ms allocated memory by class
allocated objects by gem
allocated objects by class
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
===========================================
- Coverage 100.00% 95.68% -4.32%
===========================================
Files 11 11
Lines 380 533 +153
===========================================
+ Hits 380 510 +130
- Misses 0 23 +23 ☔ View full report in Codecov by Sentry. |
Adding Experimental v2 Features 🧪 🌶️
This PR adds the features from the 2.0-develop branch to the main branch,
but as hidden / experimental features.
The intent is that users can try out the new behavior and send feedback / contribute PRs.
When option
v2_mode: true
is set, the new code paths are used.Still missing in this PR / TO DO before merging: