Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: create k3d from a config file. #265

Merged
merged 1 commit into from
Dec 5, 2022
Merged

cluster: create k3d from a config file. #265

merged 1 commit into from
Dec 5, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented Dec 3, 2022

fixes #224

Signed-off-by: Nick Santos nick.santos@docker.com

fixes #224

Signed-off-by: Nick Santos <nick.santos@docker.com>
@nicks
Copy link
Member Author

nicks commented Dec 3, 2022

ack, most of this is just wrangling the api infra. i was working on better configs for lightweight clusters and it got out of control 🥵

@nicks nicks merged commit 8df0a44 into main Dec 5, 2022
@nicks nicks deleted the nicks/network branch December 5, 2022 14:48
@almereyda
Copy link

Many thanks for this. Indeed the types went out and about.

If I may ask, is there any way to support --default-network with created registries, in so that the custom-network is used in their instantiation? I couldn't find any struct property to carry this data. It would also be some kind of hack, since this property is not present in the registries.yaml specification and K3d does not directly offer to create registries from a YAML manifest (without involving a cluster). --default-network remains available only as a CLI argument. Eventually ctlptl would want to wrap that?

This is generally useful for getting K3d to work on top of Podman, because it does not have a default bridge to which the registry could be connected. That assumes the network, to which registry and cluster will be connected, is created in advance.

@almereyda almereyda mentioned this pull request Dec 7, 2022
@krancour
Copy link

krancour commented Jan 3, 2023

The new k3d config support works great! I just wanted to say thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k3d config options
4 participants