document local minikube. Fixes https://github.com/tilt-dev/tilt/issues/3193 #1
Conversation
nicks
force-pushed
the
nicks/minikube
branch
from
f637541 to
4c0c3df
Compare
|
a ton of this is just copied and pasted from the work we did on kind-local i found that the minikube instructions recommended a bad approach, and the setup was very manual |
nicks
force-pushed
the
nicks/minikube
branch
3 times, most recently
from
97add51 to
00df6cc
Compare
|
unforuntately, had to back out the circleci test due to a minikube bug |
|
there's some discussion here kubernetes/minikube#7420, there might be a workaround, but going to do it on a separate pr |
|
...whoops I made a buncha comments straight on this commit, transferring them over to this PR :-/ |
| [](https://circleci.com/gh/tilt-dev/minikube-local) | ||
|
|
||
| When using Tilt with a [Minikube](https://minikube.sigs.k8s.io/docs/) cluster, | ||
| we recommend using a local registry for faster image pushing and pulling. |
There was a problem hiding this comment.
faster image pushing and pulling.
seems like you joinked this from a doc where the tradeoff was local registry vs. remote registry -- the main Q for minikube is about local registry vs. hooking into minikube docker, I think the docs should discuss that instead
There was a problem hiding this comment.
i think you overestimate how well most minikube users are going to understand the minikube feature set. simplified the explanation here a bit
README.md
Outdated
|
|
||
| 1) Install [Minikube](https://minikube.sigs.k8s.io/docs/) | ||
|
|
||
| 2) Copy the [minikube-with-registry.sh](minikube-with-registry.sh) somewhere on your path. |
There was a problem hiding this comment.
| 2) Copy the [minikube-with-registry.sh](minikube-with-registry.sh) somewhere on your path. | |
| 2) Copy the [minikube-with-registry.sh](minikube-with-registry.sh) script somewhere on your path. |
|
|
||
| You can now use the image name `localhost:5000/alpine` in any resources you deploy to the cluster. | ||
|
|
||
| [Tilt](https://tilt.dev) will automatically detect the local registry created by this script. |
There was a problem hiding this comment.
I thought Tilt's default was to hook into the minikube docker daemon -- if it detects a local registry, does that behavior override that behavior?
There was a problem hiding this comment.
nope!
we should change tilt to prefer the local registry over the docker daemon.
HOWEVER! This script uses containerd, so Tilt will detect that there's no docker daemon connect to
There was a problem hiding this comment.
Ooh clever! Nice. Can you open an issue/story for the local-registry-over-minikube-docker behavior?
README.md
Outdated
|
|
||
| We also have instructions for setting Minikube up with a local registry in | ||
|
|
||
| - [.circleci](.circleci) |
There was a problem hiding this comment.
removed! this is vestigial from when i thought circleci would work 😬
nicks
force-pushed
the
nicks/minikube
branch
from
00df6cc to
0f33a47
Compare
nicks
force-pushed
the
nicks/minikube
branch
from
0f33a47 to
6df2965
Compare
Hello @maiamcc,
Please review the following commits I made in branch nicks/minikube:
f637541 (2020-09-21 18:04:23 -0400)
document local minikube. Fixes tilt-dev/tilt#3193
Code review reminders, by giving a LGTM you attest that: