Skip to content

Commit

Permalink
tiltfile: prevent hang on extension fetch (#5610)
Browse files Browse the repository at this point in the history
Extensions are fetched via Git, and it's possible for SSH to
decide to prompt the user (e.g. host key verification, key file
passphrase).

We don't have an interactive session, so this results in an
indefinite hang at startup while evalutating the Tiltfile.

Fix is to pull in tilt-dev/go-get#12, which sets `-o BatchMode yes`
on SSH invocations, so that it'll fail if it would result in a
prompt, which will be propagated back to the Tiltfile logs so the
user can resolve it.
  • Loading branch information
milas authored Mar 23, 2022
1 parent e969c95 commit 3d5b00a
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 6 deletions.
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ require (
github.com/tilt-dev/dockerignore v0.1.1
github.com/tilt-dev/fsevents v0.0.0-20200515134857-2efe37af20de
github.com/tilt-dev/fsnotify v1.4.8-0.20210701141043-dd524499d3fe
github.com/tilt-dev/go-get v0.2.1
github.com/tilt-dev/go-get v0.2.2
github.com/tilt-dev/localregistry-go v0.0.0-20200615231835-07e386f4ebd7
github.com/tilt-dev/probe v0.3.1
github.com/tilt-dev/starlark-lsp v0.0.0-20220316183018-35dc2cb122f6
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1582,8 +1582,8 @@ github.com/tilt-dev/fsevents v0.0.0-20200515134857-2efe37af20de h1:tG+nJMUUxV7MJ
github.com/tilt-dev/fsevents v0.0.0-20200515134857-2efe37af20de/go.mod h1:1jUbPVh7Ani2CSublmvP7+zqTgR06A8Y0MKU9Xr2L5s=
github.com/tilt-dev/fsnotify v1.4.8-0.20210701141043-dd524499d3fe h1:dULiU6eWdUfLAO0URJz+k1zEN5B3rPS5Iupr4Srd/yk=
github.com/tilt-dev/fsnotify v1.4.8-0.20210701141043-dd524499d3fe/go.mod h1:9wJjkpCk7ADlLOAl+yIXbHwnMoV9i0+uLr9CG3D5434=
github.com/tilt-dev/go-get v0.2.1 h1:HUIbKVc6yGv+g4QfsIsjcgQKGTLIgwHFMBIFyiJzB2Q=
github.com/tilt-dev/go-get v0.2.1/go.mod h1:sqJ1OH6ggqbd2+J5TFsDGP/CXeRAXBxR52m5FtL0+xo=
github.com/tilt-dev/go-get v0.2.2 h1:FXHQDCXsicgCez2X/TljVzQS7NbJ7EbpIwLzBHIfTIU=
github.com/tilt-dev/go-get v0.2.2/go.mod h1:sqJ1OH6ggqbd2+J5TFsDGP/CXeRAXBxR52m5FtL0+xo=
github.com/tilt-dev/localregistry-go v0.0.0-20200615231835-07e386f4ebd7 h1:ysHGLJJRVcnG6WoZJt7GGD4hsMSwMxEg7Rxx4fJrSrY=
github.com/tilt-dev/localregistry-go v0.0.0-20200615231835-07e386f4ebd7/go.mod h1:bZecZHy8tHzZWeF+MEQMugKbGhi9cF1A7tuaZNIxoDs=
github.com/tilt-dev/probe v0.3.1 h1:PQhXSBkgcGBUU/eKt4vgAUKsAWWjBr2F53xNAc0E7zs=
Expand Down
16 changes: 14 additions & 2 deletions vendor/github.com/tilt-dev/go-get/get.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vendor/modules.txt
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@ github.com/tilt-dev/fsevents
# github.com/tilt-dev/fsnotify v1.4.8-0.20210701141043-dd524499d3fe
## explicit; go 1.13
github.com/tilt-dev/fsnotify
# github.com/tilt-dev/go-get v0.2.1
# github.com/tilt-dev/go-get v0.2.2
## explicit; go 1.14
github.com/tilt-dev/go-get
github.com/tilt-dev/go-get/internal/auth
Expand Down

0 comments on commit 3d5b00a

Please sign in to comment.