Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken docker_restart in live_update for docker-compose resources in versions >= 0.26.3 #5663

Closed
Sorrowwill opened this issue Apr 6, 2022 · 1 comment · Fixed by #5669
Closed
Labels
bug Something isn't working

Comments

@Sorrowwill
Copy link

Sorrowwill commented Apr 6, 2022

Expected Behavior

Tilt syncs changed files into a container, restarts it, and continue to watch files.

Current Behavior

Tilt detects changed files sync them into a container and restarts it. But after that tilt starts to sync files and restarts a container in an infinite loop. This behavior is presented only in versions starting from 0.26.3. Everything works as expected on 0.26.2

image

Steps to Reproduce

  1. Install tilt
  2. Clone docker-compose example https://github.com/tilt-dev/tilt-example-docker-compose
  3. tilt up
  4. Change server.js

Context

tilt doctor Output

$ tilt doctor
Tilt: v0.27.0, built 2022-04-01
System: linux-amd64
---
Docker
- Host: [default]
- Server Version: 20.10.14
- API Version: 1.41
- Builder: 2
- Compose Version: v1.29.2 (build 5becea4c)

About Your Use Case

We are using Tilt with docker-compose resources and are forced to stick with Tilt 0.26.2

@Sorrowwill Sorrowwill added the bug Something isn't working label Apr 6, 2022
@hyu
Copy link
Contributor

hyu commented Apr 6, 2022

Hi @Sorrowwill, thanks for detailing this issue! I was able to repro this by first checking the docker-compose example with v0.25.0, and then with v0.27.0. And I did indeed see this behavior with the infinite loop that starts as soon as you tilt up. We'll look into this and see if we can get to the bottom of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants