-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base image resource does not get deployed due to missing image #6486
Comments
thanks for the report! as a temporary workaround, i think if you set up the resource_deps so that the manifest with the base image gets deployed first, i think it will work ok. |
Thanks for the reply! Setting resource_deps does indeed help when running |
if a base image is used in ANY manifest, it needs to be pushed in all manifests. Otherwise the caching system will get confused. fixes issue #6486 Signed-off-by: Nick Santos <nick.santos@docker.com>
if a base image is used in ANY manifest, it needs to be pushed in all manifests. Otherwise the caching system will get confused. fixes issue #6486 Signed-off-by: Nick Santos <nick.santos@docker.com>
I built Tilt with the new merged changes and did not run into the issue, at least in the couple of hours I worked on my projects. However, one time I managed to get one of my deployments into a state, where I assume the base image was built with an older set of files than what was on my disk. I'm not sure how to reproduce this or if it was something that I messed up. If this doesn't ring any bells right now, I can try to check if I can make a reproducible scenario and try to figure it out later. Thanks for working on this! |
Expected Behavior
Running two resources, first one using a Dockerfile extending from the second, second using Dockerfile that is the base for the first one. Both resources, the one using the base image and the one extending the base image should deploy without an error.
Current Behavior
Steps to Reproduce
This issue can be somewhat hard to reproduce, as it feels like it's related to some race-condition.
I can consistently reproduce it with the following steps, by adding a local_resource with a sleep command and setting the resource_deps in a way that the base-image resource builds later.
Files to reproduce the issue with: test.tar.gz
Run
tilt up
Context
tilt doctor
OutputAbout Your Use Case
Use case is the ability to run the base image and see it live, while also being able to extend from it and have the changes into base image propagate into child-resources that use it.
During Tilt startup, this can be mitigated by defining resource_deps in a way that the images build in correct order, but when making changes to the images and updating the resources live, it's possible the build order is incorrect.
The text was updated successfully, but these errors were encountered: