Skip to content

tiltfile: support port-forward strings like in kubectl/dc #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2019
Merged

tiltfile: support port-forward strings like in kubectl/dc #1039

merged 1 commit into from
Jan 17, 2019

Conversation

nicks
Copy link
Member

@nicks nicks commented Jan 17, 2019

Hello @jazzdan,

Please review the following commits I made in branch nicks/ch1375/portforwards:

5b170a8 (2019-01-17 13:04:48 -0500)
tiltfile: support port-forward strings like in kubectl/dc

@nicks nicks requested a review from jazzdan January 17, 2019 18:05
jazzdan
jazzdan approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@jazzdan jazzdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicks nicks merged commit 5ef5064 into master Jan 17, 2019
@nicks nicks deleted the nicks/ch1375/portforwards branch January 17, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jazzdan jazzdan jazzdan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicks @jazzdan