Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s: inject built image digests into env vars and CRDs #1117

Merged
merged 2 commits into from
Feb 5, 2019
Merged

k8s: inject built image digests into env vars and CRDs #1117

merged 2 commits into from
Feb 5, 2019

Conversation

landism
Copy link
Member

@landism landism commented Feb 5, 2019

No description provided.

@landism landism requested review from nicks and jazzdan February 5, 2019 18:47
jazzdan
jazzdan approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@jazzdan jazzdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This was referenced Feb 5, 2019
Closed
Closed
nicks
nicks approved these changes Feb 5, 2019
View reviewed changes
internal/k8s/image.go Outdated Show resolved Hide resolved
@landism landism merged commit a1b59d7 into master Feb 5, 2019
@landism landism deleted the matt/inject_images_unstructured_and_envvars branch February 5, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazzdan jazzdan jazzdan approved these changes

@nicks nicks nicks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@landism @nicks @jazzdan