Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs: pin to node 12.16 #3382

Merged
merged 1 commit into from
May 27, 2020
Merged

nodejs: pin to node 12.16 #3382

merged 1 commit into from
May 27, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented May 27, 2020

Hello @nicks,

Please review the following commits I made in branch nicks/node12:

7dddf50 (2020-05-27 11:26:58 -0400)
nodejs: pin to node 12.16

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
Copy link
Member Author

nicks commented May 27, 2020

here's the underlying issue
nodejs/node#32852

it looks like the node 12.17 release last night broke this too

@nicks nicks merged commit 299c634 into master May 27, 2020
@nicks nicks deleted the nicks/node12 branch May 27, 2020 15:42
nicks added a commit that referenced this pull request May 27, 2020
nicks added a commit that referenced this pull request May 27, 2020
* Revert "nodejs: pin to node 12.16 (#3382)"

This reverts commit 299c634.

* upgrade babel-preset env to 7.9.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant