docker: change how we model "image builds show up in the cluster immediately" #4598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…diately" We used to treat this as a property of the cluster type + the container runtime. But this made it impossible to support clusters that sometimes use your docker runtime, and sometimes do not. For examples, see: - #4587 - #3654 - #1729 - #4544 This changes the data model so that "image builds show up in the cluster" is a property of the Docker client, not of the cluster. This should be much more flexible and correct, and help us support multiple clusters. Fixes #4544
|
This pull request has been linked to Clubhouse Story #12079: Can't start tilt with multi node minikube clusters using docker driver. |
maiamcc
reviewed
Jun 4, 2021
maiamcc
approved these changes
Jun 4, 2021
Co-authored-by: Maia McCormick <maia@windmill.engineering>
landism
pushed a commit
that referenced
this pull request
Jun 9, 2021
…diately" (#4598) * docker: change how we model "image builds show up in the cluster immediately" We used to treat this as a property of the cluster type + the container runtime. But this made it impossible to support clusters that sometimes use your docker runtime, and sometimes do not. For examples, see: - #4587 - #3654 - #1729 - #4544 This changes the data model so that "image builds show up in the cluster" is a property of the Docker client, not of the cluster. This should be much more flexible and correct, and help us support multiple clusters. Fixes #4544 * Update internal/docker/env.go Co-authored-by: Maia McCormick <maia@windmill.engineering> Co-authored-by: Maia McCormick <maia@windmill.engineering>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @maiamcc,
Please review the following commits I made in branch nicks/ch12079:
cb46eee (2021-05-27 17:28:54 -0400)
docker: change how we model "image builds show up in the cluster immediately"
We used to treat this as a property of the cluster type + the container runtime.
But this made it impossible to support clusters that sometimes use your docker
runtime, and sometimes do not.
For examples, see:
This changes the data model so that "image builds show up in the cluster"
is a property of the Docker client, not of the cluster.
This should be much more flexible and correct, and help us support multiple
clusters.
Fixes #4544
Code review reminders, by giving a LGTM you attest that: