tiltfile: use the extension api objects for file loading #5445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
most of this PR is:
(1) and (2) could probably be a separate PR; they just make less sense in isolation. |
nicks
force-pushed
the
nicks/extension
branch
from
119e28f to
a27b2aa
Compare
Now, extensions are stored in xdg home instead of being vendored in tilt_modules. You can also change the default extension repo with: ``` v1alpha1.extension_repo(name='default', url='https://github.com/my-org/my-repo', ref='my-tag') ``` at the top of the tiltfile. This should address the following issues: #3188 #3787 #4707 #3426 #5336 #5171
nicks
force-pushed
the
nicks/extension
branch
from
a27b2aa to
1904e8c
Compare
kensipe
reviewed
Feb 4, 2022
| extStatus := e.extReconciler.ForceApply(ext, repoResolved) | ||
| if extStatus.Error != "" { | ||
| return "", fmt.Errorf("loading extension %s: %s", ext.Name, extStatus.Error) | ||
| } else if extStatus.Path == "" { |
There was a problem hiding this comment.
no need for else here as well. it can collapse.
landism
approved these changes
Feb 4, 2022
Comment on lines
146
to
149
| if ext.ObjectMeta.Annotations == nil { | ||
| ext.ObjectMeta.Annotations = map[string]string{} | ||
| } | ||
| ext.ObjectMeta.Annotations[v1alpha1.AnnotationManagedBy] = "tiltfile.loader" |
There was a problem hiding this comment.
doesn't matter much, but TIL:
Comment on lines
+139
to
+143
| v1alpha1.extension_repo(name='default', url='file://%s/my-custom-repo') | ||
| v1alpha1.extension(name='my-extension', repo_name='default', repo_path='my-custom-path') | ||
|
|
||
| load("ext://my-extension", "printFoo") | ||
| printFoo() |
nicks
added a commit
to tilt-dev/tilt.build
that referenced
this pull request
Feb 4, 2022
includes all the changes from tilt-dev/tilt#5445 on new extension download semantics
nicks
added a commit
to tilt-dev/tilt.build
that referenced
this pull request
Feb 4, 2022
includes all the changes from tilt-dev/tilt#5445 on new extension download semantics
|
I got this output when It looks like things worked anyway, but the output led me to believe it didn't. |
nicks
force-pushed
the
nicks/extension
branch
from
418f5d7 to
ba76352
Compare
nicks
force-pushed
the
nicks/extension
branch
from
ba76352 to
4f17eeb
Compare
|
@landism sent you a pr for the other issue! |
nicks
added a commit
to tilt-dev/tilt.build
that referenced
this pull request
Feb 11, 2022
includes all the changes from tilt-dev/tilt#5445 on new extension download semantics
nicks
added a commit
to tilt-dev/tilt.build
that referenced
this pull request
Feb 11, 2022
* docs: rewrite the extensions guide includes all the changes from tilt-dev/tilt#5445 on new extension download semantics * Update docs/extensions.md Co-authored-by: Nick Sieger <nicksieger@gmail.com> * Update docs/extensions.md Co-authored-by: Nick Sieger <nicksieger@gmail.com> Co-authored-by: Nick Sieger <nicksieger@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @milas, @landism,
Please review the following commits I made in branch nicks/extension:
119e28f (2022-02-03 16:59:23 -0500)
tiltfile: use the extension api objects for file loading
Now, extensions are stored in xdg home instead of being vendored in tilt_modules.
You can also change the default extension repo with:
at the top of the tiltfile.
This should address the following issues:
#3188
#3787
#4707
#3426
#5336
#5171
Code review reminders, by giving a LGTM you attest that: