apiset: make ObjectSet.AddSetForType merge instead of replace #5459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ObjectSet.AddSetForType
will blow away any existing objects of the given type, but it's also much easier to read/write than looping over objects.In the Tiltfile reconciler, which has all of the uses of this method, we have a mix of calls to
ObjectSet.AddSetForType
and looping over a map and calling Add on objects individually, depending on whether the type had already been added. I added an easy-to-miss bug adding UIButtons here - my buttons blew away any buttons that were added by the Tiltfile. (similarly, if we add ToggleButton to typesWithTiltfileBuiltins, any ToggleButtons from the Tiltfile will get deleted by the later call toAddSetForType
)Solution
Make
AddSetForType
merge instead of replace. (which also makes that part of api.go cleaner!)