dockercompose: accept env_file argument
#5462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
approved these changes
Feb 7, 2022
| @@ -39,7 +39,6 @@ var dcProjectOptions = []compose.ProjectOptionsFn{ | |||
| compose.WithResolvedPaths(true), | |||
| compose.WithNormalization(true), | |||
| compose.WithOsEnv, | |||
| compose.WithDotEnv, | |||
There was a problem hiding this comment.
mostly for my curiosity - why did this change? since you seem to add it down below
There was a problem hiding this comment.
The WithDotEnv function is what actually applies and reads the file and loads it into the Environment option as key-value pairs. The default filename is .env in the current directory. WithEnvFile changes the filename, but the WithDotEnv needs to follow specifying the filename in the slice of option functions to read it.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5265.