Deprecate --hud in favor of --legacy #5470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Sipe <kensipe@gmail.com>
|
didn't run integration tests... looking at the failure and will update |
Signed-off-by: Ken Sipe <kensipe@gmail.com>
|
may need some help understand the integration env. The first failure was definitely related to the change... I don't see how the current failure is related. I'm not sure what is need to run the integration test locally and will deep later tonight |
|
@kensipe we could probably expound upon what this line means in the README. AFAIK the requirements can be satisfied by:
|
|
Thank you! long time k8s eng, first time |
|
Seems like all check pass and this is ready to go if the team sees value in it. |
|
For clarity for others that may be reading this... to run integration without make: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving UX and reducing confusion around
hudandlegacyin favor oflegacyas noted in Issue #5455Internally, it is still referenced as hud or legacy hud, but it exposed to users as
legacy.The change is much easier to reason about on startup of
upordemo.hudis marked as deprecated which requires a sleep pause in order to display. 1 sec seemed too fast to notice and guessed 3 was reasonable but looking for feedback.Additionally I guess that 3 major release versions was a reasonable deprecation window, looking for guidance there.
This PR does not handle consolidation of key navigation from prompts yet.
Signed-off-by: Ken Sipe kensipe@gmail.com