web: fix re-rendering on a few providers #5478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizzthabet
approved these changes
Feb 14, 2022
| export const FeaturesProvider = FeaturesContext.Provider | ||
| // Server-side flags are formatted as a list. | ||
| // Many tests uses the {key: value} format. | ||
| export function FeaturesProvider( |
There was a problem hiding this comment.
this is only used on the hud top-level component, right? it might be helpful to have a comment here and in the SnapshotProvider that explains when you'd use the Provider vs. theValueProvider.
There was a problem hiding this comment.
ya, i'm open to better naming on this. maybe TestProvider?
the difference is that the "real" provider wants to read other hooks for their input, but in a test provider, you just want to provide the input directly.
nicks
force-pushed
the
nicks/features
branch
from
288fba1 to
cbf8790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @lizzthabet,
Please review the following commits I made in branch nicks/features:
288fba1 (2022-02-10 16:28:38 -0500)
web: fix re-rendering on a few providers
Code review reminders, by giving a LGTM you attest that: