web: treat resources with a pending DisableStatus state as disabled #5499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
disableStatus.stateto determine a resource's disable status, instead of thedisableCount. It treats both a "disabled" and "pending" disable state as if the resource were disabled. More details are available in #5496, and this is part of the performance issue mitigation that's documented in #5495.Note: I haven't been able to very consistently reproduce a
tilt upexperience where resources show up in the UI with a pending disable state, so I haven't been able to test this fix. If reviewers are able to test locally with the debug-many-resources repo, that'd be helpful.